Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: include all props with notFound errors #2412

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Sep 14, 2021

When a workflow isn't found, include project and workflows with the returned props. Otherwise, workflow pages throw a 500 error when workflows.find() fails.

https://local.zooniverse.org:3000/projects/humphrydavy/davy-notebooks-project/classify/workflow/18244?env=production

Package:
app-project

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?

Components

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you yarn panic && yarn bootstrap or docker-compose up --build and app works as expected?

Publishing

  • Is the changelog updated?
  • Are the dependencies updated for apps and libraries that are using the newly published library?

Post-merging

When a workflow isn't found, include `project` and `workflows` with the returned props. Otherwise, workflow pages throw a 500 error when `workflows.find()` fails.
@eatyourgreens eatyourgreens added the bug Something isn't working label Sep 14, 2021
@eatyourgreens eatyourgreens requested a review from a team September 14, 2021 11:26
@mcbouslog mcbouslog requested review from mcbouslog and removed request for a team September 16, 2021 14:47
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed issue on master, confirmed expected 404 page with updates

@github-actions github-actions bot added the approved This PR is approved for merging label Sep 16, 2021
@eatyourgreens eatyourgreens merged commit 379b029 into master Sep 16, 2021
@eatyourgreens eatyourgreens deleted the fix-workflow-find branch September 16, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants