Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3 #4

Closed
wants to merge 6 commits into from
Closed

Conversation

george-hopkins
Copy link

As more and more projects are based on Python 3, this PR hopefully makes all current modules compatible with Python 3.

All tests pass for 2.7, 3.3 and 3.5: https://travis-ci.org/george-hopkins/pyutil/builds/189805907

@george-hopkins
Copy link
Author

Small update: I added an update of versioneer to get correct version tags.

CI: https://travis-ci.org/george-hopkins/pyutil/builds/189832255

george-hopkins added a commit to george-hopkins/zfec that referenced this pull request Jan 7, 2017
Until support for Python 3 [1] gets merged into pyutil, we have to install the updated version manually.

[1]: zooko/pyutil#4
george-hopkins added a commit to george-hopkins/zfec that referenced this pull request Jan 9, 2017
Until support for Python 3 [1] gets merged into pyutil, we have to install the updated version manually.

[1]: zooko/pyutil#4
@sbellem
Copy link

sbellem commented Oct 17, 2017

May we simply know what's the status on this PR? Are there plans to take care of it and merge it soon?

@zookozcash
Copy link

I'm sorry, I'm not maintaining pyutil anymore. We need someone else to maintain it!

@sbellem
Copy link

sbellem commented Oct 31, 2017

Thanks for your quick reply! (Sorry for my late reply!) I was asking because of the related PR on zfec (tahoe-lafs/zfec#4).

Just in case that it is not too much trouble for you, you can perhaps shine some light on the following question asked by @warner in tahoe-lafs/zfec#4 (comment):

What do we need pyutil for anyways? (I vaguely remember talking with zooko a long while back about maybe splitting the CLI utilities out of zfec and into a separate package, because I seem to remember that pyutil was only needed for the CLI tools).

Thanks!

@zooko
Copy link
Owner

zooko commented Oct 31, 2017 via email

@sbellem
Copy link

sbellem commented Oct 31, 2017

Best to grep the Tahoe source code to answer that, or ask someone who is a current maintainer of it.

Ok, cool, thanks!

@tpltnt
Copy link

tpltnt commented Jan 11, 2018

@george-hopkins can you do the same PR over here? I took over maintainership and would like to integrate your work.

@george-hopkins
Copy link
Author

@tpltnt Sure, I will do a rebase of my patch as soon as possible. Btw, would you mind enabling issues on your fork? That would enable us to discuss the integration in a separate thread.

@tpltnt
Copy link

tpltnt commented Jan 11, 2018

@george-hopkins cool, thank you

@tpltnt
Copy link

tpltnt commented Jan 12, 2018

Python 3 support landed in my branch and in the module on pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants