Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export of methods #219

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix export of methods #219

merged 1 commit into from
Feb 11, 2025

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Feb 6, 2025 •
edited
Loading

Purpose

This PR fixes export of some methods in Zonemaster::LDNS.

Changes

  • Method lib_version was wrongly exported to ldns_version
  • Method has_gost was missing

How to test this PR

Tests should pass.
Manual testing:

$ perl -MZonemaster::LDNS=lib_version,has_gost -E 'say "version: ", lib_version(); say has_gost() ? "true" : "false"'
version: 1.8.3
has_gost: false

@tgreenx
Fix export of methods
3368c7a 
- Method 'lib_version' was wrongly exported to 'ldns_version'
- Method 'has_gost' was missing
@tgreenx tgreenx added the V-Patch Versioning: The change gives an update of patch in version. label Feb 6, 2025
@tgreenx tgreenx added this to the v2025.1 milestone Feb 6, 2025
@marc-vanderwal
Copy link
Contributor

Travis breakage is addressed in #218.

@tgreenx tgreenx merged commit 656f69d into zonemaster:develop Feb 11, 2025
3 of 4 checks passed
@tgreenx tgreenx deleted the fix-export branch February 11, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattias-p mattias-p mattias-p approved these changes

@marc-vanderwal marc-vanderwal marc-vanderwal approved these changes

@matsduf matsduf Awaiting requested review from matsduf

@tolvmannen tolvmannen Awaiting requested review from tolvmannen

@MichaelTimbert MichaelTimbert Awaiting requested review from MichaelTimbert

Assignees
No one assigned
Labels
V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Milestone
v2025.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tgreenx @marc-vanderwal @mattias-p