Use gmake for FreeBSD #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matsduf
commented
Oct 21, 2020
matsduf
commented
- Updated Makefile.PL so that gmake is used for share/Makefile
- Updated installation instruction to include devel/gmake
- Updated MANIFEST to include yet another file under "inc"
* Updated Makefile.PL so that gmake is used for share/Makefile * Updated installation instruction to include devel/gmake * Updated MANIFEST to include yet another file under "inc"
|
Please test this on Linux too. |
ghost
reviewed
Oct 22, 2020
| @@ -9,6 +9,7 @@ docs/Translation-translators.md | |||
| inc/Module/Install.pm | |||
| inc/Module/Install/Base.pm | |||
| inc/Module/Install/Can.pm | |||
| inc/Module/Install/External.pm | |||
There was a problem hiding this comment.
This file is not present on Ubuntu :
$ make distcheck
"/usr/bin/perl" "-Iinc" "-MExtUtils::Manifest=fullcheck" -e fullcheck
No such file: inc/Module/Install/External.pm
There was a problem hiding this comment.
I suspected that. It appeared when building on FreeBSD after adding
if ($^O eq "freebsd") {
requires_external_bin 'gmake';
};
to Makefile.PL. I will investigate.
There was a problem hiding this comment.
Now inc/Module/Install/External.pm is included by the second commit. Please review again.
mattias-p
approved these changes
Oct 23, 2020
|
@PNAX, can you test again? |
ghost
requested review from
ghost
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
This works on Ubuntu.
@mattias-p sorry I misclicked for the review (and I don't know how to reset it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.