Print information on STDERR if --json has been selected #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattias-p
reviewed
Aug 16, 2018
lib/Zonemaster/CLI.pm
Outdated
| @@ -292,12 +292,14 @@ sub run { | |||
| } | |||
|
|
|||
| if ( $self->policy ) { | |||
| say __( "Loading policy from " ) . $self->policy . '.' if not ($self->dump_config or $self->dump_policy); | |||
| say __( "Loading policy from " ) . $self->policy . '.' if not ($self->dump_config or $self->dump_policy or $self->json); | |||
| warn __( "Loading policy from " ) . $self->policy . ".\n" if $self->json; | |||
There was a problem hiding this comment.
Why isn't the diagnostic printed to STDERR for the dump_policy mode? To me this diagnostic makes more sense in that mode than in any other mode.
There was a problem hiding this comment.
I cannot answer why. That is an old decision. I will update.
* Added message to STDERR of loaded policy if policy file has been selected. * Added message to STDERR of loaded config if config file has been selected.
mattias-p
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print information on selected config or policy to STDERR if --json has been selected. Keep STDOUT for other printing. Especially for normal printing STDERR would be confusing. This solves issue #77