Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles feature branch in CLI #70

Merged
merged 11 commits into from
Jan 9, 2019
Merged

Profiles feature branch in CLI #70

merged 11 commits into from
Jan 9, 2019

Conversation

mattias-p
Copy link
Member

@mattias-p mattias-p commented Apr 12, 2018 •
edited
Loading

This is a work in progress for #72.

@mattias-p mattias-p changed the title Documentation for --profile (#69) Profiles Apr 13, 2018
@mattias-p mattias-p changed the title Profiles Profiles feature branch in CLI Apr 13, 2018
@mattias-p
Merge pull request #73 from dotse/develop
7b54bb1 
Merge develop into profiles branch
@sandoche2k sandoche2k added this to the v2018.2 milestone Apr 24, 2018
sandoche2k
sandoche2k approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@sandoche2k sandoche2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattias-p shouldn't the links be clickable for example zonemaster::engine::profile

@sandoche2k
Copy link
Contributor

Need one more approval to accept the PR

@sandoche2k
Copy link
Contributor

@mattias-p please merge

@mattias-p
Copy link
Member Author

mattias-p commented Oct 17, 2018 •
edited
Loading

At this points the profiles branch contains only updates to documentation. When the implementation is made, its PR should target the profiles branch. Once the implementation has been merged into the profiles branch, the entire profiles feature with both documentation and implementation can be merged into the develop branch (preferably using this PR).

@sandoche2k
Copy link
Contributor

@mattias-p can you merge?

@sandoche2k
Copy link
Contributor

@mattias-p can this PR be merged?

@sandoche2k
Copy link
Contributor

@mattias-p pls. merge

@mattias-p
Copy link
Member Author

@sandoche2k As soon as zonemaster/zonemaster-engine#386 is merged.

@sandoche2k
Copy link
Contributor

@mattias-p merge?

@mattias-p mattias-p merged commit b5276f7 into develop Jan 9, 2019
@matsduf matsduf deleted the profiles branch May 27, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

@matsduf matsduf matsduf approved these changes

@sandoche2k sandoche2k sandoche2k approved these changes

@vlevigneron vlevigneron Awaiting requested review from vlevigneron

Assignees

@mattias-p mattias-p

Labels
None yet
Projects
None yet
Milestone
v2018.2
Development

Successfully merging this pull request may close these issues.
5 participants
@mattias-p @sandoche2k @bombsimon @matsduf @vlevigneron