Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects gettext code and adds dependency required by CI (Travis) #398

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Corrects gettext code and adds dependency required by CI (Travis) #398

merged 2 commits into from
Nov 25, 2024

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Nov 22, 2024 •
edited
Loading

Purpose

How to test this PR

  • Review
  • Unit test should work
  • Run zonemaster-cli with input data that should be captured, e.g. non-existing profile file.

@matsduf matsduf added T-Bug Type: Bug in software or error in test case description P-High Priority: Issue to be solved before other V-Patch Versioning: The change gives an update of patch in version. labels Nov 22, 2024
@matsduf matsduf added this to the v2024.2 milestone Nov 22, 2024
This was referenced Nov 22, 2024
Closed
Merged
@matsduf matsduf force-pushed the correct-gettext-and-update-ci branch from ed84749 to b65d5f5 Compare November 23, 2024 15:26
@matsduf matsduf merged commit 30bef12 into zonemaster:develop Nov 25, 2024
1 check passed
@matsduf matsduf deleted the correct-gettext-and-update-ci branch November 25, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-vanderwal marc-vanderwal marc-vanderwal approved these changes

@tgreenx tgreenx tgreenx approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

@tolvmannen tolvmannen Awaiting requested review from tolvmannen

@MichaelTimbert MichaelTimbert Awaiting requested review from MichaelTimbert

Assignees
No one assigned
Labels
P-High Priority: Issue to be solved before other T-Bug Type: Bug in software or error in test case description V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Milestone
v2024.2
Development

Successfully merging this pull request may close these issues.
3 participants
@matsduf @tgreenx @marc-vanderwal