Improved test coverage #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* --restore option * --save option * Deprecated options --json-translate and --encoding * Underscore option aliases
* --count * --elapsed * --nstimes
mattias-p
added
the
V-Patch
mattias-p
requested review from
matsduf,
tgreenx,
marc-vanderwal and
MichaelTimbert
matsduf
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Scope
This PR concerns itself with validation and dispatching of user-provided command line options to zonemaster-cli.
Limitations:
Goal
This PR aims to establish a sufficient regression testing suite for the stated scope. It would be great if we didn't need to perform any manual testing for this particular aspect of the application when switching out the command line parsing library.
Context
As part of #68 we plan to drop our dependency on Moose and MooseX::Getopt::GLD. That will affect every command line option in zonemaster-cli.
Changes
Fixes the handling of invalid --hints argument.
New tests are added for options and option combinations:
To help finding gaps in test coverage I added support for Devel::Cover in usage.t.
This PR also includes some cleanups.
How to test this PR
Unit test should pass.
Special considerations when reviewing this PR