Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove planned deprecated '--sourceaddr' option #370

Merged
merged 1 commit into from
May 14, 2024

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented May 7, 2024

Purpose

This PR removes planned deprecated --sourceaddr option.

Context

Relates to zonemaster/zonemaster-engine#1343

How to test this PR

There should be no trace in the code, or documentation of the --sourceaddr option.

Also:

$ zonemaster-cli zonemaster.net --sourceaddr 1.2.3.4
Unknown option: --sourceaddr
Run "zonemaster-cli -h" to get the valid options

@tgreenx tgreenx added the V-Major Versioning: The change gives an update of major in version. label May 7, 2024
@tgreenx tgreenx added this to the v2024.1 milestone May 7, 2024
@tgreenx tgreenx merged commit d9d6fce into zonemaster:develop May 14, 2024
@tgreenx tgreenx deleted the remove-deprecated branch May 14, 2024 08:38
@marc-vanderwal
Copy link
Contributor

Successfully tested without issues.

The command-line option --sourceaddr is no longer recognized.

I couldn’t find any trace of --sourceaddr in the documentation of zonemaster-cli --help, nor in man zonemaster-cli.

The msgids in the .po files still mention --sourceaddr but I presume that these will be removed at the next translation update.

@marc-vanderwal marc-vanderwal added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ReleaseTested Status: The PR has been successfully tested in release testing V-Major Versioning: The change gives an update of major in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants