Update option 'list_tests' #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove POD extraction. This is no longer useful after the changes in zonemaster-engine#1277.
tgreenx
requested review from
mattias-p,
matsduf,
hannaeko,
a user and
marc-vanderwal
tgreenx
added
the
V-Patch
marc-vanderwal
approved these changes
Sep 13, 2023
matsduf
approved these changes
Sep 14, 2023
tgreenx
added
V-Minor
v2023.2 Release TestingI successfully tested this on Rocky Linux 8.9. N.B. The description says that it is only the test case IDs that are printed, but the output actually also includes the module names. I'm guessing this is what's intended though. |
mattias-p
added
the
S-ReleaseTested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates option
list_testsby removing the use of the POD extraction function (Zonemaster::Engine::Util/pod_extract_for()) of Test Case methods.This is no longer useful after the changes in zonemaster/zonemaster-engine#1277, where that function is removed (by commit zonemaster/zonemaster-engine@0631ee0). See comment.
Context
Relates to zonemaster/zonemaster-engine#1277 (specifically commit zonemaster/zonemaster-engine@0631ee0)
Changes
lib/Zonemaster/CLI.pmHow to test this PR
Run
zonemaster-cli --list_testsand check that only the Test Cases IDs are outputted.