-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spanish translation as requested in issue #322 #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a Spanish speaker, but I see no issues either.
@huguei, do you want to take a second review before we merge? We do not have any speaking Spanish here. |
I did a second check and it seems ready to go. Please proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't speak Spanish, I have just one comment but otherwise it looks fine.
"Only one domain can be given for testing. Did you forget to prepend an " | ||
"option with '--<OPTION>'?\n" | ||
msgstr "" | ||
"Solo puede indicarse 1 dominio para las pruebas. ¿Quizás incluyó una opción " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the translated string (msgstr) the numeral of "one" is provided ("1"), while the original string (msgid) does not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huguei, please comment. Should it be updated? If yes, I can easily do it if you write to what.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you careful review @tgreenx , but no, it's clearer with a number. In Spanish the word "un" can indicate an indefinite article ("a/an") or the number 1, and in this case saying "Solo puede indicarse un dominio para las pruebas" is pretty vague. Sounds equivalent to "only any domain can be given for testing". In contrast, "only 1 domain can be indicated for testing" is unambiguous that it refers to quantity!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @huguei! I will merge.
Purpose
This PR updates spanish translation to keep in sync with develop branch.
Please note poedit tool reorder the messages so it appears more changes than effective.
Context
#322
Changes
share/es.po