New options "--sourceaddr4" and "--sourceaddr6"

[ghost]

Purpose

Provide options to define both source IPv4 and source IPv6. This would replace the --sourceaddr option.

Context

#315
Follow-up on zonemaster/zonemaster-engine#1203

Changes

• New options "--sourceaddr4" and "--sourceaddr6"
• Deprecate "--sourceaddr".

How to test this PR

zonemaster-cli --sourceaddr <IP address> bzh # should emit a deprecation message
zonemaster-cli --sourceaddr4 <IPv4 address> berlin
zonemaster-cli --sourceaddr6 <IPv6 address> tokyo

[matsduf]

Add a blocker so that --sourceaddr can neither be combined with --sourceaddr4 nor --sourceaddr6.

[ghost]

Add a blocker so that --sourceaddr can neither be combined with --sourceaddr4 nor --sourceaddr6.

Done.

Add [...] "Cannot be combined with --sourceaddr".

Done.

[matsduf]

It should be noted that zonemaster-cli will this update will require Zonemaster::Engine updated as updated with zonemaster/zonemaster-engine#1203.

[tgreenx]

v2023.1 Release testing

Basic testing:

• New options "--sourceaddr4" and "--sourceaddr6". --> OK
• Deprecate "--sourceaddr". --> OK

Observations:

• Setting a valid IPv4 address with --sourceaddr works.
• Setting a valid IPv6 address with --sourceaddr works.
• Setting an invalid IPv4 address with --sourceaddr fails silently.
• Setting an invalid IPv6 address with --sourceaddr fails silently.
• Setting a valid IPv4 address with --sourceaddr4 works.
• Setting a valid IPv6 address with --sourceaddr6 works.
• Setting an invalid IPv4 address with --sourceaddr4 fails silently.
• Setting an invalid IPv6 address with --sourceaddr6 fails silently.
• Setting a valid IPv4 address with --sourceaddr6 fails silently.
• Setting a valid IPv6 address with --sourceaddr4 fails silently.
• Setting an invalid IPv4 address with --sourceaddr6 fails silently.
• Setting an invalid IPv6 address with --sourceaddr4 fails silently.
• Any combination above using --no-ipv4 or --no-ipv6 works as expected.