Handle hints files named "0" #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a hints file named "0" was given on the command-line, it wasn’t read. The code simply checked whether $self->hints is a truthy value; however, in Perl, the string "0" is falsey. Checking for definedness instead of truthiness is more robust. It also helps guard against the case when a user gives --hints "", which is obviously wrong and should cause zonemaster-cli to error out.
marc-vanderwal
added
the
T-Bug
marc-vanderwal
requested review from
mattias-p,
matsduf,
hannaeko,
a user and
tgreenx
matsduf
approved these changes
Dec 13, 2022
matsduf
added
the
V-Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a programming oversight causing
zonemaster-clito disregard hints files named0.Context
Follow-up to #284.
Changes
Change a test for truthiness to a test for definedness.
How to test this PR
0.zonemaster-cli --hints 0 test.Error loading hints file: read_file '0' - open: No such file or directory. (The erroneous behavior was thatzonemaster-cliattempts to run a test, disregarding the--hintsoption.)