Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing installation instructions for CentOS Linux 7 (CLI) #275

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Jun 22, 2022

Purpose

This PR adds missing installation instructions for CentOS Linux 7 (CentOS). The support for CentOS was removed in the v2021.2 release, but was readded in v2022.1 release. The installation instructions were not added.

How to test this PR

This is documentation only.

@matsduf matsduf requested review from mattias-p, hannaeko, a user, tgreenx and marc-vanderwal June 22, 2022 19:45
@matsduf matsduf added P-High Priority: Issue to be solved before other A-Documentation Area: Documentation only. labels Jun 22, 2022
@matsduf matsduf added this to the v2022.1.1 milestone Jun 22, 2022
mattias-p
mattias-p previously approved these changes Jul 6, 2022
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but it look to me like it would work.

docs/Installation.md Outdated Show resolved Hide resolved
tgreenx
tgreenx previously approved these changes Jul 6, 2022
Copy link
Contributor

@tgreenx tgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I didn't actually try the installation steps.

@matsduf matsduf dismissed stale reviews from tgreenx and mattias-p via 37b1f61 July 6, 2022 14:42
@matsduf matsduf requested a review from mattias-p July 6, 2022 14:42
@matsduf matsduf merged commit fc2c349 into zonemaster:develop Jul 6, 2022
@matsduf matsduf deleted the update-installation-instruction-missing-centos branch July 6, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Documentation Area: Documentation only. P-High Priority: Issue to be solved before other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants