remove domains final dots #253
Conversation
lib/Zonemaster/CLI.pm
Outdated
| @@ -601,6 +603,8 @@ sub add_fake_delegation { | |||
| exit( 1 ); | |||
| } | |||
|
|
|||
| $name =~ s/\.$// unless $name eq '.';; | |||
There was a problem hiding this comment.
To resolve zonemaster/zonemaster-engine#1055 the code must remove multiple trailing dots. Cf zonemaster/zonemaster-backend#983 (comment)
There was a problem hiding this comment.
typo: two semi-colons
fixed
lib/Zonemaster/CLI.pm
Outdated
| @@ -601,6 +603,8 @@ sub add_fake_delegation { | |||
| exit( 1 ); | |||
| } | |||
|
|
|||
| $name =~ s/\.$// unless $name eq '.';; | |||
There was a problem hiding this comment.
To resolve zonemaster/zonemaster-engine#1055 the code must remove multiple trailing dots. Cf zonemaster/zonemaster-backend#983 (comment)
|
I took the same approach as zonemaster/zonemaster-backend#983 and return an error if consecutive dots are found in names. |
lib/Zonemaster/CLI.pm
Outdated
| exit( 1 ); | ||
| } | ||
|
|
||
| if ( $name =~ m/\.\./i ) { | ||
| say STDERR __x( "The name of the nameserver '{ns}' contains consecutive dots.", ns => $name ); |
There was a problem hiding this comment.
In a msgid in Zonemaster-Engine, an argument for this type must be "nsname". It would be good to use the same definitions here because it makes it easier for the translator. See https://github.com/zonemaster/zonemaster-engine/blob/develop/docs/logentry_args.md
|
@matsduf please re-review |
1 similar comment
|
@matsduf please re-review |
Missing Spanish locale in Installation document
matsduf
added
the
S-ReleaseTested
Purpose
Do not crash when a domain is specified with a final dot.
Context
zonemaster/zonemaster-engine#1055
Changes
How to test this PR
../zonemaster-cli/script/zonemaster-cli --ns ns2.nic.fr. zonemaster.net. --show-testcaseshould run the test without crashing../zonemaster-cli/script/zonemaster-cli --ns ns2.nic.fr.. zonemaster.net. --show-testcaseshould show an error../zonemaster-cli/script/zonemaster-cli --ns ns2.nic.fr. zonemaster.net.. --show-testcaseshould show an error