Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centos installation #119

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Centos installation #119

merged 2 commits into from
Oct 23, 2019

Conversation

mattias-p
Copy link
Member

@mattias-p mattias-p commented Oct 18, 2019 •
edited
Loading

Fixes #117.

Also cleans up a useless explicit dependency on a core module.

@matsduf
Copy link
Contributor

matsduf commented Oct 18, 2019

This looks fine, but travis is unhappy.

@mattias-p mattias-p force-pushed the centos-installation branch from bac080c to c1e53dc Compare October 23, 2019 10:07
@mattias-p mattias-p requested a review from matsduf October 23, 2019 11:04
matsduf
matsduf approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but the description of the PR does not cover the change in Makefile.PL. Please update that before merge.

@mattias-p mattias-p merged commit 0f66dd2 into zonemaster:develop Oct 23, 2019
@matsduf matsduf mentioned this pull request Nov 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsduf matsduf matsduf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattias-p @matsduf