Normalize domain column #1005
Normalize domain column #1005
Conversation
ghost
added this to the 
ghost
requested review from
|
I guess this requires a database update to normalize all stored domains. This could be done in a second stage, once this PR is approved. |
It would be nice, including down-casing the domain name, it is however, not strictly necessary by this PR. The issue of domain names being stored with and without trailing dot is an old issue. |
With PR #798 we normalize the way we store the "params" data in database. The "domain" column should also be normalized, especially since it's used by get_test_history() method.
|
I updated the upgrade script since this change would alter how |
|
I found a problem during release testing and I created #1030 to fix it. |
|
After the fix in #1030 I successfully tested this for v2022.1. |
mattias-p
added
the
S-ReleaseTested
Purpose
Store the normalized domain value in the "domain" column in database.
Context
Follow-up of #983
Changes
Database files.
Normalize passed "domain" in get_test_history() before retrieval (since domains are now normalized in database).
Update the upgrade script.
How to test this PR
Unit tests are added, they should pass. Or start a test with a trailing dot to the domain (and/or with uppercase letters), the domain stored in database should be normalized.
Using the upgrade script should remove any trailing dot from the domain column, as well as down casing it.