Handle the case when js code returns a regexp from a function #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short, it fixes #10 .
That particular problem was caused by lack of handling the special case when a function contained return statement followed by a regular expression. The code treated initial slash of regexp as division operator, so the quote inside the regexp was treated as the beginning of a string, and so on, and so forth.
For example, an attempt to minify the code below caused
unterminated single quoted string literal
error.Now it works. And it seems like minification of CKEditor mentioned in znuny/Znuny#6 goes well too (though, that should be double checked).