This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
Keep interface parity with PushNotificationIOS #909
Merged
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on iOS will continue to pass through to PushNotificationIOS, but android will leverage NotificationManager to retrieve and cancel relevant notifications.
khanhduy62
approved these changes
Oct 6, 2019
|
Thanks @Dallas62 for jumping into this one. I had forgotten it was here. Anything I can do to help get this merged in? |
|
Hi @sginn |
Dallas62
approved these changes
Apr 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PushNotificationIOS implements removeAllDeliveredNotifications, getDeliveredNotifications and removeDeliveredNotifications.
React-native-push-notification is a wrapper over that interface for iOS. keeping parity avoids some Platform checks