Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bms assignment yatharth #55

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Bms assignment yatharth #55

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f63a95d
Dummy push
Jun 19, 2023
3ea60af
BMS_Implementation_Yatharth
Jun 19, 2023
56ec068
BMS_Implementation - Screen files added
Jun 19, 2023
45db271
BMS_BASE_URL
Jun 19, 2023
5ccc0c4
Assertion syntax corrected
Jun 20, 2023
e411128
Screenshots added
Jun 20, 2023
dd01436
Comments removed
Jun 20, 2023
5da785d
Percentage logic updated
Jun 20, 2023
8a2b99a
Merge branch 'main' into BMS_Assignment_Yatharth
Yatharth-P Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Percentage logic updated
  • Loading branch information
Yatharth Pandya authored and Yatharth Pandya committed Jun 20, 2023
commit 5da785d2504e743809f4d8d826b382db7eacfff8
2 changes: 1 addition & 1 deletion src/test/java/com/znsio/sample/e2e/businessLayer/bms/BMSSelectSeatsBL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public BMSSelectSeatsBL validateAvailableSeatsPercentage(String validationPercen

double validatePercent = Double.parseDouble(validationPercentage);
LOGGER.info("Vacant seats should be greater than " + validatePercent + " %");
double actualPercentageOfVacantSeats = totalAvailableSeats/totalSeats;
double actualPercentageOfVacantSeats = (totalAvailableSeats/totalSeats)*100;
LOGGER.info("Actual vacant seats are " + actualPercentageOfVacantSeats + " %");

softly.assertThat(actualPercentageOfVacantSeats).as("Actual vacant seat percentage is lower than Validation percentage").isGreaterThan(validatePercent);
Expand Down