Skip to content

Commit

Permalink
iox-eclipse-iceoryx#1900 Revert change of byte to a distinct type
Browse files Browse the repository at this point in the history
Signed-off-by: Ziad Mostafa <[email protected]>
  • Loading branch information
Ziad Mostafa committed Feb 21, 2023
1 parent e5a15d5 commit b679719
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
3 changes: 0 additions & 3 deletions doc/website/release-notes/iceoryx-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@
- Remove `algorithm::uniqueMergeSortedContainers` from `algorithm.hpp`
- Move `std::string` conversion function to `iceoryx_dust` [\#1612](https://github.com/eclipse-iceoryx/iceoryx/issues/1612)
- The posix call `unlink` is directly used in `UnixDomainSocket` [\#1622](https://github.com/eclipse-iceoryx/iceoryx/issues/1622)
- Make iox::byte_t a distinct type [\#1900](https://github.com/eclipse-iceoryx/iceoryx/issues/1900)

**Workflow:**

Expand Down Expand Up @@ -1023,8 +1022,6 @@
#include "iox/duration.hpp"
```
46. Renaming `byte_t` to `byte`
`byte` is not a simple type alias, now it is a distinct type like c++17 `std::byte`.
The type `byte` does not support any arithmetic operations nor has member functions.

```cpp
//before
Expand Down
6 changes: 2 additions & 4 deletions iceoryx_hoofs/primitives/include/iox/iceoryx_hoofs_types.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@

namespace iox
{

enum class byte : uint8_t
{
};
/// @todo iox-#1900 use std::byte with c++17
using byte = uint8_t;

// AXIVION Next Construct AutosarC++19_03-M2.10.1 : log is a sensible namespace for a logger; furthermore it is in the
// iox namespace and when used as function the compiler will complain
Expand Down

0 comments on commit b679719

Please sign in to comment.