Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(boards): Add Corne-ish Zen v1 #1593

Merged
merged 5 commits into from
Apr 26, 2023
Merged

feat(boards): Add Corne-ish Zen v1 #1593

merged 5 commits into from
Apr 26, 2023

Conversation

caksoylar
Copy link
Contributor

@caksoylar caksoylar commented Dec 17, 2022 •
edited
Loading

This PR does some minor refactoring for existing Corne-ish Zen v2 files and adds files for Corne-ish Zen v1 (for GB rounds 1&2).

  • Spacing and duplicated Kconfig clean up
  • Set a chosen transform in the board files (in case someone writes their keymap from scratch and doesn't do that)
  • Tweak compatible and model values in the DT

v1's differences compared to v2 are:

  • Battery sensing with the fuel gauge, with power domain support through int-gpios that was necessary for deep sleep in Zephyr 3.x
    • Does not enable or use additional sensor channels from the fuel gauge chip
  • Uses spi2 instead of spi0 since fuel gauge uses i2c0

For v2 refactorings the produced DTS and Kconfig files after a build are identical to main except for model and compatible values that removed v2. Tested right side on real v1 hardware, although I have been using a (non-unified) branch with the same config until my v1 left side died.

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

petejohanson
petejohanson reviewed Dec 17, 2022
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

app/boards/arm/corneish_zen/Kconfig.board Show resolved Hide resolved
app/boards/arm/corneish_zen/corneish_zen_v1_right.dts Outdated Show resolved Hide resolved
@caksoylar caksoylar mentioned this pull request Dec 17, 2022
Closed
@manna-harbour
Copy link

Thanks @caksoylar!

Currently testing with this build (current ZMK main, mousekeys enabled, layer widget disabled): https://github.com/manna-harbour/miryoku_zmk/actions/runs/3727371035.

@caksoylar caksoylar added enhancement New feature or request board PRs and issues related to boards. labels Dec 19, 2022
@manna-harbour
Copy link

Haven't noticed any issues since I started testing.

@caksoylar caksoylar marked this pull request as ready for review January 5, 2023 23:45
@caksoylar
Copy link
Contributor Author

We had another user confirm on the LPKB Discord so I am publishing the PR for review.

@lulzsun
Copy link

lulzsun commented Feb 2, 2023 •
edited
Loading

Confirmed to be working on my Corne-ish Zen v1 and no issues so far either. Thanks!

petejohanson
petejohanson reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions. Thanks.

app/boards/arm/corneish_zen/corneish_zen_v1_left_defconfig Outdated Show resolved Hide resolved
app/boards/arm/corneish_zen/corneish_zen_v1_right.dts Outdated Show resolved Hide resolved
app/boards/arm/corneish_zen/corneish_zen_v1_right_defconfig Outdated Show resolved Hide resolved
@caksoylar caksoylar force-pushed the add-zen-v1 branch 3 times, most recently from 0b5141c to 8180b7a Compare March 26, 2023 21:55
@aterisetri aterisetri mentioned this pull request Mar 31, 2023
Closed
@caksoylar
Copy link
Contributor Author

Rebased and have been testing (just the right side) OK for a few days now.

petejohanson
petejohanson approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson
Copy link
Contributor

@caksoylar Looks like the pre-commit check is still not happy with this.

@caksoylar
Copy link
Contributor Author

I hadn't managed to install pre-commit locally properly, hope it's all good now!

@petejohanson petejohanson merged commit 0239f18 into zmkfirmware:main Apr 26, 2023
@caksoylar caksoylar deleted the add-zen-v1 branch April 27, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petejohanson petejohanson petejohanson approved these changes

Assignees
No one assigned
Labels
board PRs and issues related to boards. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caksoylar @manna-harbour @lulzsun @petejohanson