Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add array.groupByMap #1004

Merged
merged 1 commit into from
Dec 9, 2021
Merged

feat: add array.groupByMap #1004

merged 1 commit into from
Dec 9, 2021

Conversation

Jack-Works
Copy link
Contributor

No description provided.

@Jack-Works
Copy link
Contributor Author

That proposal also adds https://tc39.es/proposal-array-grouping/#sec-array.prototype.groupbymap but no %TypedArray%.prototype.groupBy

@zloirock
Copy link
Owner

zloirock commented Nov 3, 2021

Thanks! It's already tracked here #1001, however, I'll get some moments from this PR.

@Jack-Works
Copy link
Contributor Author

I have removed TypedArray.groupBy

@zloirock
Copy link
Owner

zloirock commented Nov 3, 2021

@Jack-Works it's a breaking change, so it can be removed only in core-js@4.

@Jack-Works
Copy link
Contributor Author

@Jack-Works it's a breaking change, so it can be removed only in core-js@4.

I reverted that change. Do core-js provide semver constraints even for proposals? I thought proposals are unstable

@zloirock
Copy link
Owner

zloirock commented Nov 3, 2021

Yes, sure. Breaking changes can be only in cases that most likely still no one used, like removing @@species support from Array.prototype.groupBy in #1001. Removing esnext.typed-array.group-by will break too many cases of code generated by @babel/preset-env.

@zloirock zloirock merged commit 4d91951 into zloirock:master Dec 9, 2021
@zloirock
Copy link
Owner

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants