fix new detection in Number constructor, close #89, babel/babel#1927

zloirock · Jul 5, 2015 · f047bbc · f047bbc
1 parent c7b2eac
commit f047bbc
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/library/modules/es6.number.constructor.js b/library/modules/es6.number.constructor.js
@@ -1,5 +1,6 @@
 'use strict';
 var $          = require('./$')
+  , cof        = require('./$.cof')
   , isObject   = $.isObject
   , isFunction = $.isFunction
   , NUMBER     = 'Number'
@@ -24,7 +25,7 @@ function toNumber(it){
 }
 if($.FW && !($Number('0o1') && $Number('0b1'))){
   $Number = function Number(it){
-    return this instanceof $Number ? new Base(toNumber(it)) : toNumber(it);
+    return this instanceof $Number && cof(this) != NUMBER ? new Base(toNumber(it)) : toNumber(it);
   };
   $.each.call($.DESC ? $.getNames(Base) : (
       // ES3:

diff --git a/modules/es6.number.constructor.js b/modules/es6.number.constructor.js
@@ -1,5 +1,6 @@
 'use strict';
 var $          = require('./$')
+  , cof        = require('./$.cof')
   , isObject   = $.isObject
   , isFunction = $.isFunction
   , NUMBER     = 'Number'
@@ -24,7 +25,7 @@ function toNumber(it){
 }
 if($.FW && !($Number('0o1') && $Number('0b1'))){
   $Number = function Number(it){
-    return this instanceof $Number ? new Base(toNumber(it)) : toNumber(it);
+    return this instanceof $Number && cof(this) != NUMBER ? new Base(toNumber(it)) : toNumber(it);
   };
   $.each.call($.DESC ? $.getNames(Base) : (
       // ES3:

diff --git a/tests/tests.js b/tests/tests.js
diff --git a/tests/tests/es6.number.constructor.ls b/tests/tests/es6.number.constructor.ls
@@ -60,6 +60,9 @@ test 'Number constructor: regression' !->
 
   for <[MAX_VALUE MIN_VALUE NaN NEGATIVE_INFINITY POSITIVE_INFINITY]>
     ok .. of Number, "#{..} in Number"
+
+  n = new Number 42
+  eq typeof n@@(n), \number
 
 test 'Number constructor: binary' !->
   check \0b1, 1