move require to heads of files, enable some related eslint rules

.eslintrc.js

@@ -1,4 +1,6 @@
 'use strict';
+const webpack = require('./.webpack.config.js');
+
 const base = {
   // possible errors:
   // enforce 'for' loop update clause moving the counter in the right direction
@@ -257,12 +259,18 @@ const base = {
   'unicode-bom': ['error', 'never'],
 
   // commonjs:
+  // require require() calls to be placed at top-level module scope
+  'global-require': 'error',
+  // disallow require calls to be mixed with regular variable declarations
+  'no-mixed-requires': ['error', { grouping: true, allowCall: false }],
   // disallow new operators with calls to require
   'no-new-require': 'error',
   // disallow string concatenation with `__dirname` and `__filename`
   'no-path-concat': 'error',
 
   // import:
+  // ensure all imports appear before other statements
+  'import/first': 'error',
   // forbid AMD imports
   'import/no-amd': 'error',
   // forbid cycle dependencies
@@ -504,7 +512,7 @@ module.exports = {
   settings: {
     'import/resolver': {
       webpack: {
-        config: require('./.webpack.config.js').options,
+        config: webpack.options,
       },
     },
   },

Gruntfile.js

@@ -1,5 +1,6 @@
 /* eslint-disable unicorn/filename-case */
 'use strict';
+const webpack = require('./.webpack.config.js');
 const { banner } = require('./packages/core-js-builder/config');
 
 process.env.CHROME_BIN = require('puppeteer').executablePath();
@@ -161,9 +162,11 @@ module.exports = grunt => {
         ].map(src => ({ src })),
       },
     },
-    webpack: require('./.webpack.config.js'),
+    webpack,
   });
   grunt.registerTask('bundle', function () {
+    // some dependencies of this module generated in grunt tasks, so we should load it here
+    // eslint-disable-next-line global-require
     const builder = require('./packages/core-js-builder');
     const done = this.async();
 

packages/core-js-builder/config.js

@@ -1,8 +1,10 @@
 'use strict';
+const { version } = require('./package');
+
 module.exports = {
   /* eslint-disable prefer-template */
   banner: '/**\n' +
-          ' * core-js ' + require('./package').version + '\n' +
+          ' * core-js ' + version + '\n' +
           ' * https://github.com/zloirock/core-js\n' +
           ' * License: http://rock.mit-license.org\n' +
           ' * © ' + new Date().getFullYear() + ' Denis Pushkarev (zloirock.ru)\n' +

packages/core-js-compat/src/build-entries.js

@@ -4,7 +4,8 @@ const { dirname, resolve } = require('path');
 const detective = require('detective');
 const { sync: glob } = require('glob');
 const intersection = require('core-js-pure/features/set/intersection');
-const order = new Set(Object.keys(require('./data')));
+const data = require('./data');
+const order = new Set(Object.keys(data));
 
 function getModulesForEntryPoint(entry) {
   const match = entry.match(/\/modules\/([^/]+)$/);

packages/core-js-pure/override/internals/collection.js

@@ -1,6 +1,6 @@
 'use strict';
+var $ = require('./export');
 var global = require('../internals/global');
-var $export = require('./export');
 var InternalMetadataModule = require('../internals/internal-metadata');
 var fails = require('../internals/fails');
 var hide = require('../internals/hide');
@@ -9,9 +9,11 @@ var anInstance = require('../internals/an-instance');
 var isObject = require('../internals/is-object');
 var setToStringTag = require('../internals/set-to-string-tag');
 var defineProperty = require('../internals/object-define-property').f;
-var each = require('../internals/array-methods')(0);
+var arrayMethods = require('../internals/array-methods');
 var DESCRIPTORS = require('../internals/descriptors');
 var InternalStateModule = require('../internals/internal-state');
+
+var forEach = arrayMethods(0);
 var setInternalState = InternalStateModule.set;
 var internalStateGetterFor = InternalStateModule.getterFor;
 
@@ -39,7 +41,7 @@ module.exports = function (CONSTRUCTOR_NAME, wrapper, common, IS_MAP, IS_WEAK) {
 
     var getInternalState = internalStateGetterFor(CONSTRUCTOR_NAME);
 
-    each(['add', 'clear', 'delete', 'forEach', 'get', 'has', 'set', 'keys', 'values', 'entries'], function (KEY) {
+    forEach(['add', 'clear', 'delete', 'forEach', 'get', 'has', 'set', 'keys', 'values', 'entries'], function (KEY) {
       var IS_ADDER = KEY == 'add' || KEY == 'set';
       if (KEY in NativePrototype && !(IS_WEAK && KEY == 'clear')) hide(Constructor.prototype, KEY, function (a, b) {
         var collection = getInternalState(this).collection;
@@ -59,7 +61,7 @@ module.exports = function (CONSTRUCTOR_NAME, wrapper, common, IS_MAP, IS_WEAK) {
   setToStringTag(Constructor, CONSTRUCTOR_NAME, false, true);
 
   exported[CONSTRUCTOR_NAME] = Constructor;
-  $export({ global: true, forced: true }, exported);
+  $({ global: true, forced: true }, exported);
 
   if (!IS_WEAK) common.setStrong(Constructor, CONSTRUCTOR_NAME, IS_MAP);
 

packages/core-js-pure/override/internals/set-to-string-tag.js

@@ -1,8 +1,10 @@
 var defineProperty = require('../internals/object-define-property').f;
 var hide = require('../internals/hide');
 var has = require('../internals/has');
-var TO_STRING_TAG = require('../internals/well-known-symbol')('toStringTag');
 var toString = require('../internals/object-to-string');
+var wellKnownSymbol = require('../internals/well-known-symbol');
+
+var TO_STRING_TAG = wellKnownSymbol('toStringTag');
 var METHOD_REQUIRED = toString !== ({}).toString;
 
 module.exports = function (it, TAG, STATIC, SET_METHOD) {

packages/core-js-pure/override/modules/es.date.to-json.js

@@ -1,15 +1,17 @@
 'use strict';
+var $ = require('../internals/export');
 var toObject = require('../internals/to-object');
 var toPrimitive = require('../internals/to-primitive');
 var toISOString = require('../internals/date-to-iso-string');
 var classof = require('../internals/classof-raw');
+var fails = require('../internals/fails');
 
-var FORCED = require('../internals/fails')(function () {
+var FORCED = fails(function () {
   return new Date(NaN).toJSON() !== null
     || Date.prototype.toJSON.call({ toISOString: function () { return 1; } }) !== 1;
 });
 
-require('../internals/export')({ target: 'Date', proto: true, forced: FORCED }, {
+$({ target: 'Date', proto: true, forced: FORCED }, {
   // eslint-disable-next-line no-unused-vars
   toJSON: function toJSON(key) {
     var O = toObject(this);

packages/core-js-pure/override/modules/es.regexp.constructor.js

@@ -1 +1,3 @@
-require('../internals/set-species')('RegExp');
+var setSpecies = require('../internals/set-species');
+
+setSpecies('RegExp');

packages/core-js-pure/override/modules/web.dom-collections.iterator.js

@@ -3,7 +3,9 @@ var DOMIterables = require('../internals/dom-iterables');
 var global = require('../internals/global');
 var hide = require('../internals/hide');
 var Iterators = require('../internals/iterators');
-var TO_STRING_TAG = require('../internals/well-known-symbol')('toStringTag');
+var wellKnownSymbol = require('../internals/well-known-symbol');
+
+var TO_STRING_TAG = wellKnownSymbol('toStringTag');
 
 for (var COLLECTION_NAME in DOMIterables) {
   var Collection = global[COLLECTION_NAME];

packages/core-js/es/array-buffer/constructor.js

@@ -1,4 +1,5 @@
 require('../../modules/es.array-buffer.constructor');
 require('../../modules/es.object.to-string');
+var path = require('../../internals/path');
 
-module.exports = require('../../internals/path').ArrayBuffer;
+module.exports = path.ArrayBuffer;

packages/core-js/es/array-buffer/index.js

@@ -2,5 +2,6 @@ require('../../modules/es.array-buffer.constructor');
 require('../../modules/es.array-buffer.is-view');
 require('../../modules/es.array-buffer.slice');
 require('../../modules/es.object.to-string');
+var path = require('../../internals/path');
 
-module.exports = require('../../internals/path').ArrayBuffer;
+module.exports = path.ArrayBuffer;

packages/core-js/es/array-buffer/is-view.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array-buffer.is-view');
+var path = require('../../internals/path');
 
-module.exports = require('../../internals/path').ArrayBuffer.isView;
+module.exports = path.ArrayBuffer.isView;

packages/core-js/es/array/concat.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.concat');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'concat');
+module.exports = entryUnbind('Array', 'concat');

packages/core-js/es/array/copy-within.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.copy-within');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'copyWithin');
+module.exports = entryUnbind('Array', 'copyWithin');

packages/core-js/es/array/entries.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.iterator');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'entries');
+module.exports = entryUnbind('Array', 'entries');

packages/core-js/es/array/every.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.every');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'every');
+module.exports = entryUnbind('Array', 'every');

packages/core-js/es/array/fill.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.fill');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'fill');
+module.exports = entryUnbind('Array', 'fill');

packages/core-js/es/array/filter.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.filter');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'filter');
+module.exports = entryUnbind('Array', 'filter');

packages/core-js/es/array/find-index.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.find-index');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'findIndex');
+module.exports = entryUnbind('Array', 'findIndex');

packages/core-js/es/array/find.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.find');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'find');
+module.exports = entryUnbind('Array', 'find');

packages/core-js/es/array/flat-map.js

@@ -1,4 +1,5 @@
 require('../../modules/es.array.flat-map');
 require('../../modules/es.array.unscopables.flat-map');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'flatMap');
+module.exports = entryUnbind('Array', 'flatMap');

packages/core-js/es/array/flat.js

@@ -1,4 +1,5 @@
 require('../../modules/es.array.flat');
 require('../../modules/es.array.unscopables.flat');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'flat');
+module.exports = entryUnbind('Array', 'flat');

packages/core-js/es/array/for-each.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.for-each');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'forEach');
+module.exports = entryUnbind('Array', 'forEach');

packages/core-js/es/array/from.js

@@ -1,4 +1,5 @@
 require('../../modules/es.string.iterator');
 require('../../modules/es.array.from');
+var path = require('../../internals/path');
 
-module.exports = require('../../internals/path').Array.from;
+module.exports = path.Array.from;

packages/core-js/es/array/includes.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.includes');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'includes');
+module.exports = entryUnbind('Array', 'includes');

packages/core-js/es/array/index-of.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.index-of');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'indexOf');
+module.exports = entryUnbind('Array', 'indexOf');

packages/core-js/es/array/index.js

@@ -28,5 +28,6 @@ require('../../modules/es.array.species');
 require('../../modules/es.array.splice');
 require('../../modules/es.array.unscopables.flat');
 require('../../modules/es.array.unscopables.flat-map');
+var path = require('../../internals/path');
 
-module.exports = require('../../internals/path').Array;
+module.exports = path.Array;

packages/core-js/es/array/is-array.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.is-array');
+var path = require('../../internals/path');
 
-module.exports = require('../../internals/path').Array.isArray;
+module.exports = path.Array.isArray;

packages/core-js/es/array/iterator.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.iterator');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'values');
+module.exports = entryUnbind('Array', 'values');

packages/core-js/es/array/join.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.join');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'join');
+module.exports = entryUnbind('Array', 'join');

packages/core-js/es/array/keys.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.iterator');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'keys');
+module.exports = entryUnbind('Array', 'keys');

packages/core-js/es/array/last-index-of.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.last-index-of');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'lastIndexOf');
+module.exports = entryUnbind('Array', 'lastIndexOf');

packages/core-js/es/array/map.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.map');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'map');
+module.exports = entryUnbind('Array', 'map');

packages/core-js/es/array/of.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.of');
+var path = require('../../internals/path');
 
-module.exports = require('../../internals/path').Array.of;
+module.exports = path.Array.of;

packages/core-js/es/array/reduce-right.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.reduce-right');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'reduceRight');
+module.exports = entryUnbind('Array', 'reduceRight');

packages/core-js/es/array/reduce.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.reduce');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'reduce');
+module.exports = entryUnbind('Array', 'reduce');

packages/core-js/es/array/reverse.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.reverse');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'reverse');
+module.exports = entryUnbind('Array', 'reverse');

packages/core-js/es/array/slice.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.slice');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'slice');
+module.exports = entryUnbind('Array', 'slice');

packages/core-js/es/array/some.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.some');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'some');
+module.exports = entryUnbind('Array', 'some');

packages/core-js/es/array/sort.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.sort');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'sort');
+module.exports = entryUnbind('Array', 'sort');

packages/core-js/es/array/splice.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.splice');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'splice');
+module.exports = entryUnbind('Array', 'splice');

packages/core-js/es/array/values.js

@@ -1,3 +1,4 @@
 require('../../modules/es.array.iterator');
+var entryUnbind = require('../../internals/entry-unbind');
 
-module.exports = require('../../internals/entry-unbind')('Array', 'values');
+module.exports = entryUnbind('Array', 'values');

packages/core-js/es/array/virtual/concat.js

@@ -1,3 +1,4 @@
 require('../../../modules/es.array.concat');
+var entryVirtual = require('../../../internals/entry-virtual');
 
-module.exports = require('../../../internals/entry-virtual')('Array').concat;
+module.exports = entryVirtual('Array').concat;

packages/core-js/es/array/virtual/copy-within.js

@@ -1,3 +1,4 @@
 require('../../../modules/es.array.copy-within');
+var entryVirtual = require('../../../internals/entry-virtual');
 
-module.exports = require('../../../internals/entry-virtual')('Array').copyWithin;
+module.exports = entryVirtual('Array').copyWithin;

packages/core-js/es/array/virtual/entries.js

@@ -1,3 +1,4 @@
 require('../../../modules/es.array.iterator');
+var entryVirtual = require('../../../internals/entry-virtual');
 
-module.exports = require('../../../internals/entry-virtual')('Array').entries;
+module.exports = entryVirtual('Array').entries;

packages/core-js/es/array/virtual/every.js

@@ -1,3 +1,4 @@
 require('../../../modules/es.array.every');
+var entryVirtual = require('../../../internals/entry-virtual');
 
-module.exports = require('../../../internals/entry-virtual')('Array').every;
+module.exports = entryVirtual('Array').every;

packages/core-js/es/array/virtual/fill.js

@@ -1,3 +1,4 @@
 require('../../../modules/es.array.fill');
+var entryVirtual = require('../../../internals/entry-virtual');
 
-module.exports = require('../../../internals/entry-virtual')('Array').fill;
+module.exports = entryVirtual('Array').fill;