Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/prover sync #221

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Fix/prover sync #221

merged 6 commits into from
Jul 19, 2024

Conversation

AllFi
Copy link

@AllFi AllFi commented Jul 11, 2024 •
edited
Loading

This PR fixes two issues:

  1. If the prover tries to synchronize the state before the indexer has synchronized with the contract, the attempt to build the proveTreeUpdate transaction fails, and the prover gets stuck.
  2. A successfully mined appendDirectDeposits transaction updates the state, breaking the synchronization process and causing the prover to get stuck.

@AllFi AllFi requested review from EvgenKor, lok52 and r0wdy1 July 12, 2024 09:47
@AllFi AllFi marked this pull request as ready for review July 12, 2024 09:47
r0wdy1
r0wdy1 approved these changes Jul 15, 2024
View reviewed changes
Copy link

@r0wdy1 r0wdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllFi AllFi merged commit a82c66b into feature/decentralized-relayer Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvgenKor EvgenKor EvgenKor approved these changes

@lok52 lok52 lok52 approved these changes

@r0wdy1 r0wdy1 r0wdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AllFi @EvgenKor @lok52 @r0wdy1