Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Nil pointer in GetTokenIDAndSubjectFromToken #732

Closed
wants to merge 1 commit into from
Closed

Fix: Nil pointer in GetTokenIDAndSubjectFromToken #732

wants to merge 1 commit into from

Conversation

Fotkurz
Copy link

@Fotkurz Fotkurz commented Mar 26, 2025

Definition of Ready

Related story

Fixing a bug related to a nil pointer that could happen if the claims tokenIdClaims returned nil from the private method.

Also added a few unit tests for this whole method.

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@Fotkurz Fotkurz mentioned this pull request Mar 26, 2025
Open
2 tasks
@Fotkurz Fotkurz closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
os-contribution
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fotkurz @hifabienne