This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
update aes to 0.8 #354
Merged
update aes to 0.8 #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(hazard): The changelog in aes doesn't indicate any change in behaviour, and I have assumed the new APIs work identically
|
I'll merge this on Tuesday if we don't find a reason it shouldn't be added :) |
aquacash5
reviewed
Feb 14, 2023
|
|
||
| use aes::cipher::generic_array::GenericArray; | ||
| use aes::{BlockEncrypt, NewBlockCipher}; | ||
| // use aes::{BlockEncrypt, NewBlockCipher}; |
There was a problem hiding this comment.
Should remove unused commented code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(hazard): The changelog in aes doesn't indicate any change in behaviour, and I have assumed the new APIs work identically
This closes #352. Lets check that the CI likes it.
@mbr! As the author of the original PR, would love your input here - do you think any more changes need to be made to support the newer
aes?