Logger config #668
Logger config #668
Conversation
|
| /** | ||
| * A `LogPattern` is string representation of `LogFormat` | ||
| */ | ||
| sealed trait LogPattern { |
There was a problem hiding this comment.
I wonder if we should call this SerializableLogFormat, or perhaps, LogFormat.Serializable or something.
The presence of toLogFormat suggests that it might be or should be a subtype of LogFormat.
Expressing that relationship in the name could be useful. Also moving it to the companion object of LogFormat could be useful if it's not as commonly used as LogFormat, and we want to hide it a bit or emphasize it's a derivative of LogFormat.
| def name: String | ||
| } | ||
|
|
||
| sealed trait Arg1[A1] extends Arg { |
There was a problem hiding this comment.
The type parameters here become erased because they are not tracked in the supertype.
Which means this is practically equivalent to def arg1: Any, etc.
I wonder if, instead of doing it this way, we can either delete Arg1 and Arg2, or embed type-safe capabilities into these treats, which lets clients of the traits use the arguments in some safe way?
loggers configuration support
added
LogPattern, which is string representation ofLogFormat- zio-parser is used for parsingremoved scala 2.11 support