do not allow selection to contain duplicates

[PythonFZ]

No description provided.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.70%. Comparing base (d61512a) to head (b3ccd0c).

Files	Patch %	Lines
tests/test_selection.py	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   50.19%   49.70%   -0.50%     
==========================================
  Files          26       26              
  Lines        2002     2010       +8     
==========================================
- Hits         1005      999       -6     
- Misses        997     1011      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RokasEl]

Why don't you just filter duplicates in the selection rather than raising a ValueError?

[PythonFZ]

Why don't you just filter duplicates in the selection rather than raising a ValueError?

My motivation was, to let the user know that duplicates will not be possible. When filtering them silently e.g. via list(set(...)), they will not notice that something might be wrong.

[RokasEl]

Perhaps throw a warning instead? My worry is that something might happen in the webclient to accidentally cause a double selection. We don't want value errors thrown around in that case.

[PythonFZ]

Perhaps throw a warning instead? My worry is that something might happen in the webclient to accidentally cause a double selection. We don't want value errors thrown around in that case.

The webclient uses a set for selection, so it should not be possible to cause any issue there:

ZnDraw/app/src/App.tsx

Line 71 in d61512a

const [selectedIds, setSelectedIds] = useState<Set<number>>(new Set());

[RokasEl]

In which case I think this is fine to merge.