Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulsarv3: update values, default to 3.0.7, enabled for new milvus #214

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

haorenfsa
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.54%. Comparing base (26f348b) to head (40e369f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apis/milvus.io/v1beta1/milvus_webhook.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   80.58%   80.54%   -0.05%     
==========================================
  Files          56       56              
  Lines        6275     6282       +7     
==========================================
+ Hits         5057     5060       +3     
- Misses       1027     1030       +3     
- Partials      191      192       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm looks good to merge label Jan 23, 2025
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LoveEachDay,haorenfsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5f3e10b into zilliztech:main Jan 23, 2025
15 checks passed
@haorenfsa haorenfsa deleted the pulsar-version branch January 23, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants