Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:support headless service for proxy component #138

Closed

Conversation

qchenzi
Copy link

@qchenzi qchenzi commented Jun 25, 2024

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qchenzi
To complete the pull request process, please assign loveeachday after the PR has been reviewed.
You can assign the PR to them by writing /assign @loveeachday in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Collaborator

Welcome @qchenzi! It looks like this is your first PR to zilliztech/milvus-operator 🎉

@haorenfsa
Copy link
Collaborator

Instead of changing current service update function, I suggest adding a new one when headless is enabled. And an option to enable headless service is also needed.

@haorenfsa
Copy link
Collaborator

Hi @qchenzi, do you still intend to add this patch ?

@qchenzi
Copy link
Author

qchenzi commented Jul 8, 2024

Hi @haorenfsa

I have decided not to proceed with adding this patch at this time. Thank you for your guidance and support throughout this process. I may revisit this in the future if the need arises.

Best regards

@qchenzi qchenzi closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants