Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use symfony token manager for ajax #3505

Closed
wants to merge 0 commits into from
Closed

use symfony token manager for ajax #3505

wants to merge 0 commits into from

Conversation

craigh
Copy link
Member

@craigh craigh commented Mar 30, 2017

Q A
Bug fix? yes
New feature? yes
BC breaks? no?
Deprecations? yes
Fixed tickets -
Refs tickets #3206
License MIT
Changelog updated [yes/no]

Description

A few sentences describing the overall goals of the pull request's commits.

Todos

  • Tests
  • Documentation
  • Changelog

@craigh craigh added this to the 1.5.0 milestone Mar 30, 2017
@craigh craigh self-assigned this Mar 30, 2017
@craigh craigh requested a review from Guite March 30, 2017 14:47
@craigh
Copy link
Member Author

craigh commented Mar 30, 2017

this is the basic idea. I guess the \Zikula\Core\Token\CsrfTokenHandler class would be refactored to use symfony's also

@Guite
Copy link
Member

Guite commented Mar 30, 2017

Looks good. Just wondering whether all existing ajax POST requests will fail if they do not explicitly send the token variable in their payload though 🤔

@Guite
Copy link
Member

Guite commented Mar 30, 2017

Changelog?

@craigh
Copy link
Member Author

craigh commented Mar 30, 2017

Changelog?

yes, stuff to do yet, I wanted your opinion on the basic idea

@craigh craigh mentioned this pull request Apr 1, 2017
@craigh craigh closed this Apr 6, 2017
@craigh craigh deleted the CsrfToken branch April 6, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants