Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fc #3335

Merged
merged 7 commits into from
Dec 28, 2016
Merged

Fc #3335

merged 7 commits into from
Dec 28, 2016

Conversation

craigh
Copy link
Member

@craigh craigh commented Dec 28, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
Refs tickets #3307
License MIT
Changelog updated no

Description

remove legacy calls and update to new methods

@craigh craigh added this to the 1.4.5 milestone Dec 28, 2016
@craigh craigh requested a review from Guite December 28, 2016 16:37
Guite
Guite reviewed Dec 28, 2016
View reviewed changes
Copy link
Member

@Guite Guite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Please review default values for constructor args of ExceptionListener.

@craigh craigh merged commit 9d37184 into 1.4 Dec 28, 2016
@craigh craigh deleted the FC branch December 28, 2016 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guite Guite Guite left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@craigh @Guite