Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate UserEntity on registration. #3263

Merged
merged 3 commits into from
Dec 4, 2016
Merged

validate UserEntity on registration. #3263

merged 3 commits into from
Dec 4, 2016

Conversation

craigh
Copy link
Member

@craigh craigh commented Dec 4, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #3256
Refs tickets -
License MIT
Changelog updated not yet

Description

fixes #3256

To do

  • add changelog

@craigh craigh added this to the 1.4.4 milestone Dec 4, 2016
@craigh craigh self-assigned this Dec 4, 2016
@craigh
Copy link
Member Author

craigh commented Dec 4, 2016

Do not merge this yet, I still must check admin creation of users. This should fix the initial problem though.

@craigh
Copy link
Member Author

craigh commented Dec 4, 2016

@Guite @rallek can you test this solution before it is merged?

@Guite
Copy link
Member

Guite commented Dec 4, 2016

I think a changelog entry is adequate.

@rallek
Copy link
Contributor

rallek commented Dec 4, 2016

A guest is still able to create a user account with the name of an existing user :-(

@Guite Guite merged commit 52e63f6 into 1.4 Dec 4, 2016
@Guite Guite deleted the issue-3256 branch December 4, 2016 17:09
Guite added a commit that referenced this pull request Dec 4, 2016
@craigh
Copy link
Member Author

craigh commented Dec 4, 2016

Do not merge this yet, I still must check admin creation of users

thanks 🙄

@Guite
Copy link
Member

Guite commented Dec 4, 2016

sorry I thought it would have been done as you asked for testing 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants