add install checker #3023
add install checker #3023
Conversation
| use Symfony\Component\Console\Output\OutputInterface; | ||
| use Zikula\Bundle\CoreBundle\YamlDumper; | ||
|
|
||
| class UpgradeResetCommand extends ContainerAwareCommand |
There was a problem hiding this comment.
So this is only here for Travis, right?
There was a problem hiding this comment.
I don't see that it would be useful for anything else, no.
There was a problem hiding this comment.
I think it would be more appropriate not to add this command but update the version using a shell command inside the travis.yml file.
|
|
This is finished. please review. |
| @@ -79,25 +76,23 @@ public function initPhp() | |||
|
|
|||
| public function requirementsMet(ContainerInterface $container) | |||
| { | |||
| // several other requirements are checked before Symfony is loaded. | |||
There was a problem hiding this comment.
So below only Zikula-specific checks remain, right?
|
Nice addition 😄 |
| function_exists('mb_get_info'), | ||
| 'mbstring is not installed in PHP. Zikula cannot install or upgrade without this extension.', | ||
| 'Install and enable the <strong>mbstring</strong> extension' | ||
| ); |
There was a problem hiding this comment.
This can be removed as well.
|
I've replaced the upgrade command now with the |
It's working 🎉 Only thing left to do is to remove the command file you introduced. |
Description
Add Symfony Installer's requirements check to our own installation and upgrade processes. Update and improve install and upgrade docs. Eliminate the use of system constants to indicate currently installed version and replace with permanently written parameter.