Change getPluralOffset to return numbers and not boolean values #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change the function getPluralOffset will return numbers and not boolean values. This change is required because the function getPluralMessage uses this value as offset to access array keys.
|
Thank you for the contribution! please fix StyleCI issues. After, if you know how, please squash the commits (soft reset, force push) so there is only one commit. If not, no problem. Also please create a PR for 1.4 |
|
also - please add a changelog entry. |
|
ping @gfr :) |
this is no longer necessary. Github magic will do it now. |
|
Closed in favour of #3010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the function getPluralOffset will return numbers and not boolean values. This change is required because the function getPluralMessage uses this value as offset to access array keys.