Refactor BlocksModule and create BlockApi. #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
craigh
commented
Dec 13, 2015
craigh
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes! |
| Fixed tickets | - |
| Refs tickets | - |
| License | MIT |
| Doc PR | included |
| Changelog updated | yes |
- Fix module stylesheet not being loaded automatically for Core-2.0 modules.
- New advanced block filtering based on a combination of any query parameter or request attributes.
- Implement new BlockApi and all corresponding methods.
- Added AbstractExtensionInstaller for use by third-party developers.
- Added ExtensionVariablesTrait for developers to insert into classes where Extension Variable management is needed.
| Q | A | ----------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes! | Fixed tickets | - | Refs tickets | - | License | MIT | Doc PR | included | Changelog updated | yes - Fix module stylesheet not being loaded automatically for Core-2.0 modules. - New advanced block filtering based on a combination of any query parameter or request attributes. - Implement new BlockApi and all corresponding methods. - Added AbstractExtensionInstaller for use by third-party developers. - Added ExtensionVariablesTrait for developers to insert into classes where Extension Variable management is needed.
This was referenced Dec 13, 2015
Closed
|
Please note: this adds phpunit tests to the travis build. |
| @@ -17,6 +17,7 @@ | |||
| use Symfony\Component\DependencyInjection\ContainerInterface; | |||
| use Zikula\Bundle\CoreBundle\Twig; | |||
| use Zikula\Bundle\CoreBundle\Twig\Extension\SimpleFunction\AdminMenuPanelSimpleFunction; | |||
| use Zikula\Core\AbstractModule; | |||
There was a problem hiding this comment.
Seems like this is not needed.
|
👍 |
| */ | ||
| private function wrapBlockContentWithUniqueDiv($content, $positionName, $blockType, $bid) | ||
| { | ||
| return '<div class="z-block ' |
There was a problem hiding this comment.
I have already mentioned about this to @craigh This is another remnant of "pre bootstrap age". We do not need to add any html/css at this stage, this can be added in block template. This makes difficult to arrange blocks in block position using bootstrap grid.
There was a problem hiding this comment.
after this is merged open a ticket for further discussion.
There was a problem hiding this comment.
Yes, please open a separate ticket. I personally think we should keep the additional classes, but let's discuss in another ticket.
craigh
added a commit
that referenced
this pull request
Dec 13, 2015
Refactor BlocksModule and create BlockApi.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.