[1.3] Load correct theme in case Mobile theme is enabled and Mobile detect is enabled #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tect is also enabled, but client is not mobile
…tect is also enabled, but client is not mobile
craigh
added a commit
that referenced
this pull request
Sep 9, 2015
…m_Printer_RSS [1.3] Load correct theme in case Mobile theme is enabled and Mobile detect is enabled
|
should have asked for a changelog entry before merging. can you please submit another PR? also - you should be aware that there may not actually be a 1.3.11 release... not sure. |
|
Yes, I also hope 1.4 branch soon to become so stable as 1.3 branch :-) |
nmpetkov
added a commit
to nmpetkov/core
that referenced
this pull request
Sep 9, 2015
craigh
added a commit
that referenced
this pull request
Sep 9, 2015
…m_Printer_RSS Changelog entry for #2583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to Zikula 1.3 branch only, and corrects a bug in default theme loading in case Mobile theme is enabled and Mobile detect is also enabled, but client is not mobile.
In particular, if described conditions occurs, then "Printer" and "RSS" themes, passed in URL, will not load.