Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert system and themes to PSR-4 #2563

Merged
merged 35 commits into from
Aug 23, 2015
Merged

Convert system and themes to PSR-4 #2563

merged 35 commits into from
Aug 23, 2015

Conversation

craigh
Copy link
Member

@craigh craigh commented Aug 17, 2015

Convert all system modules and all system themes to PSR-4. maintain BC.

REQUIRES COMPOSER UPDATE !!!

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes*
Tests pass? yes
Fixed tickets -
Refs tickets #2424
License MIT
Doc PR -
Changelog updated yes
  • deprecated items are only a result of namespace changes and a BC layer has been added to compensate.

@craigh craigh added this to the 1.4.1 milestone Aug 17, 2015
craigh added 2 commits August 16, 2015 21:17
…nerated as part of the upgrade process, so additional steps not required to compensate for change from psr-0 to psr-4.
@craigh
Copy link
Member Author

craigh commented Aug 17, 2015

I think this is ready but would really appreciate some additional testing. @Guite @phaidon @cmfcmf @Kaik

@craigh
Copy link
Member Author

craigh commented Aug 17, 2015

refs #2424

@Kaik
Copy link
Contributor

Kaik commented Aug 18, 2015

I was away for some time now I hope to be able to come back to this soon I need few more days and I will do all the tests and check all the new stuff.

@craigh craigh mentioned this pull request Aug 20, 2015
@craigh
Copy link
Member Author

craigh commented Aug 22, 2015

I think this is ready but would really appreciate some additional testing.

wow, was I wrong. 🎱 ⛵

but now, I think it really is ready, but nobody tests with me. 😢 😭

@craigh craigh changed the title [WIP] Convert system and themes to PSR-4 Convert system and themes to PSR-4 Aug 22, 2015
@craigh
Copy link
Member Author

craigh commented Aug 22, 2015

Will be merging this Sunday afternoon (EDT) if there are no objections. @Guite @phaidon @cmfcmf @Kaik

@Guite
Copy link
Member

Guite commented Aug 23, 2015

I just tested a new installation on my local machine which worked fine. Afterwards I clicked a bit through administration and changed several settings. This worked flawlessly as well.

So 👍 from me - and thank your for all this work!

craigh added a commit that referenced this pull request Aug 23, 2015
Convert system and themes to PSR-4
@craigh craigh merged commit d1e34a6 into 1.4 Aug 23, 2015
@craigh craigh deleted the psr-4 branch August 23, 2015 19:00
@cmfcmf
Copy link
Contributor

cmfcmf commented Aug 24, 2015

Thank you @craigh.

@craigh craigh mentioned this pull request Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants