Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable 'advanced' handling of RouteNotFoundException #2508

Merged
merged 2 commits into from
Jun 23, 2015

Conversation

craigh
Copy link
Member

@craigh craigh commented Jun 23, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
Refs tickets #2470
License MIT
Doc PR -
Changelog updated no

disable (at least temporarily) 'advanced' handling of RouteNotFoundException. The redirects have caused issues before and can cause endless redirects. There are specific issues when adminpanelmenu is in use because it expects routes to be available. This PR reduces handling to be the same error message for admin and normal users.

refs #2470 (probably)

@cmfcmf @Guite and any others - please share your concerns. I would like to merge this into 1.4.0

…ception. The redirects have caused issues before and can cause endless redirects. There are specific issues when `adminpanelmenu` is in use because it expects routes to be available. This PR reduces handling to be the same error message for admin and normal users.

refs #2470 (probably)
@craigh craigh added this to the 1.4.0 milestone Jun 23, 2015
@Guite
Copy link
Member

Guite commented Jun 23, 2015

👍 keep it simple
maybe it would be possible to add a link for admins so the reload page is only one click away?

@craigh
Copy link
Member Author

craigh commented Jun 23, 2015

maybe it would be possible to add a link

added.

@cmfcmf
Copy link
Contributor

cmfcmf commented Jun 23, 2015

👍 👍

craigh added a commit that referenced this pull request Jun 23, 2015
disable 'advanced' handling of RouteNotFoundException
@craigh craigh merged commit 116cb9e into 1.4 Jun 23, 2015
@cmfcmf cmfcmf deleted the exception-listener-fix branch June 23, 2015 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants