[Extensions] Incompatible modules get saved now #2220
Conversation
Incompatible modules get saved into the database now with state set to incompatible. | Q | A | ----------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #1641 | Refs tickets | - | License | MIT | Doc PR | - | Changelog updated | yes
|
Puh. I was happy to be able to create this PR. |
|
yes, we need PR's for both branches at the same time so they do not get out of sync. |
| @@ -1434,7 +1453,7 @@ public function updatehooks($args) | |||
|
|
|||
| // Delete hook regardless | |||
| $where = "WHERE $hookscolumn[smodule] = '" . DataUtil::formatForStore($modinfo['name']) . "' | |||
| AND $hookscolumn[tmodule] <> ''"; | |||
| AND $hookscolumn[tmodule] <> ''"; | |||
There was a problem hiding this comment.
I disagree with this (and following) formatting change
|
most of this looks OK I think. you can make changes locally and push a new commit to the same branch and the changes will be reflected in the PR (if you did not already know this). |
@Portugao - check in 1.4. and see if the problem even exists there. I worked on this issue I think a while ago and maybe already fixed it there. please check. |
|
for example in 1.4 I have this:
|
|
Is that what you would expect? |
|
@craigh Yes. |
|
👍 great! so no need for a 1.4 PR 😉 |
|
I checked too, it works for me in 1.4. Fine. |
[Extensions] Incompatible modules get saved now
Incompatible modules get saved into the database now with state set to
incompatible.