Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include webshims using composer #3262

Closed
Guite opened this issue Dec 4, 2016 · 0 comments
Closed

Include webshims using composer #3262

Guite opened this issue Dec 4, 2016 · 0 comments
Assignees
@Guite
Labels
UI/UX
Milestone
1.4.5

Comments

@Guite
Copy link
Member

Guite commented Dec 4, 2016 •
edited
Loading

Currently webshims is included in javascript. It should be replaced by composer.
https://github.com/aFarkas/webshim/blob/master/composer.json

Ensure that dev/shims/FlashCanvasPro/proxy.php is still blocked, see #3260

Twig polyfill function and JCSSUtil must be updated to use the new pathes afterwards.
@Guite Guite added this to the 1.4.5 milestone Dec 4, 2016
@Guite Guite mentioned this issue Dec 6, 2016
Merged
@Guite Guite self-assigned this Dec 6, 2016
@craigh craigh closed this as completed in 75c113a Dec 8, 2016
craigh added a commit that referenced this issue Dec 8, 2016
@craigh
Merge pull request #3271 from zikula/issue-3262
939bbbd 
fetch webshim using composer, fixed #3262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guite Guite

Labels
UI/UX
Projects
None yet
Milestone
1.4.5
Development

No branches or pull requests
1 participant
@Guite