Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove PersistentModuleHandlers from /system modules #1545

Closed
4 tasks done
craigh opened this issue Jan 10, 2014 · 0 comments
Closed
4 tasks done

remove PersistentModuleHandlers from /system modules #1545

craigh opened this issue Jan 10, 2014 · 0 comments
Assignees
@craigh
Labels
Blocker
Milestone
1.4.0

Comments

@craigh
Copy link
Member

craigh commented Jan 10, 2014

refactor for Dependency Injection

  • Extensions
  • Search
  • Settings
  • Users
@ghost ghost assigned craigh Jan 10, 2014
This was referenced Jan 10, 2014
Closed
Merged
ghost pushed a commit that referenced this issue Jan 21, 2014
Merge pull request #1560 from craigh/dependencyInjection
76ae1da 
This PR was merged into zikula:1.3 branch.

Discussion
----------

Convert system modules to Dependency Injection

When this PR is merged, the profiler will report several errors like "ERROR - Event handler was not attached for event 'get.pending_content' because method 'Zikula\Module\UsersModule\Listener\PendingContentListener::pendingContentListener' is not callable" **this is expected behavior** if (and only if) you are using a development version of the core. Once you reinstall the core or run `upgrade.php` on your original site, this will be take care of. Instead, one can also safely manually delete the `/EventHandler` entries in the `module_vars` table for the **core modules**. if you cannot live with the red errors in your profiler bar.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #1545
| Refs tickets  | -
| License       | MIT
| Doc PR        | -

Commits
-------

0f1646f refactor Users module to use DependencyInjection. refs #1545 craigh
116902c refactor Search module to use DependencyInjection. refs #1545 craigh
1ab0fec refactor Settings module to use DependencyInjection. refs #1545 craigh
83ac114 refactor Extensions module to use DependencyInjection. refs #1545 craigh
db2950e refactor Extensions module to use DependencyInjection. refs #1545 craigh
432c1b2 revert individual module upgrade routines and handle all in the main upgrade.php file instead. craigh
7851b5b corrections and split listeners into more descriptively named classes and change service names to match. craigh
381c334 CS fixes craigh
@ghost ghost closed this as completed Jan 21, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craigh craigh

Labels
Blocker
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
1 participant
@craigh