Fix type hints for tuples #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also ensures that the field types always have `is_type_val == true` which unfortunately regresses the ability to destructure tuple that are made of types.
Techatrix
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
As you may have noticed, handling tuple types has two possible code paths, one for Analyser.Type.Data.tuple and one for Analyser.Type.Data.container which is unnecessarily complicated.
I started out experimenting this to see if there any issues but ended up doing the entire change myself so I pushed it to your branch. I hope you don't mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2065