Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate-c: promote int literals to bigger types #8126

Merged
merged 5 commits into from
Mar 11, 2021
Merged

translate-c: promote int literals to bigger types #8126

merged 5 commits into from
Mar 11, 2021

Conversation

xackus
Copy link
Contributor

@xackus xackus commented Mar 2, 2021 •
edited
Loading

My attempt at solving #4479 (which should probably be renamed).
@Vexu What do you think about this?

TODO:

  • Previously integer literals without a suffix weren't given a type using @as. Giving it is probably more correct, but noisy. Decide what to do.
  • Fix translate-c tests.
  • Add translate-c/run-translated-c tests.

Vexu
Vexu approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@Vexu Vexu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra noise is unfortunate but correct behavior is more important.

@xackus
Copy link
Contributor Author

xackus commented Mar 5, 2021

@Vexu By the way, great job with the AST changes in translate-c!

@xackus xackus force-pushed the translate_c_int_literal_promotion branch from 9cbdd7b to 0e6a8a6 Compare March 5, 2021 18:42
@xackus xackus force-pushed the translate_c_int_literal_promotion branch from 0e6a8a6 to 937c522 Compare March 5, 2021 20:04
@xackus xackus marked this pull request as ready for review March 5, 2021 20:06
@xackus xackus force-pushed the translate_c_int_literal_promotion branch from 937c522 to eda1b53 Compare March 5, 2021 20:22
@xackus xackus requested a review from Vexu March 10, 2021 10:26
@andrewrk andrewrk merged commit 4fc6f63 into ziglang:master Mar 11, 2021
@xackus xackus mentioned this pull request Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vexu Vexu Awaiting requested review from Vexu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xackus @Vexu @andrewrk