Stop using std.Buffer in places that don't make sense #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikskuh
suggested changes
Feb 7, 2020
daurnimator
force-pushed
the
less-buffer
branch
from
898e5cd to
2169308
Compare
|
Perhaps |
daurnimator
force-pushed
the
less-buffer
branch
3 times, most recently
from
5e312c9 to
3e413bc
Compare
This comment has been minimized.
This comment has been minimized.
Buffer's behaviour of retaining a trailing 0 isn't helpful here
daurnimator
force-pushed
the
less-buffer
branch
2 times, most recently
from
6abf2d1 to
1106de2
Compare
daurnimator
added
the
standard library
|
Thanks @daurnimator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I imagine due to its name,
std.Bufferis used in many places that it shouldn't be. (Related: #4385)This PR moves many use-sites over to more-correct APIs