std.io.Poller: handle EPIPE as EOF #22075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps time to bump this then? Lines 532 to 537 in e2f24a2 |
|
Indeed |
|
Any idea why 11.7.1 in particular was selected in #13299, as opposed to simply 11.0.0? It seems oddly specific and it's not obvious to me why. Was it just because it was the latest version of macOS 11 at the time of the bump? |
andrewrk
force-pushed
the
fix-broken-pipe
branch
from
ff87ab4 to
54a7742
Compare
|
Yeah, it's just the minimum version that was practical to run. I think using zeroes is probably better unless there was some crucial bug fix we need to depend on. |
Apple has already dropped support for macOS 12. GitHub Actions is dropping macOS 12 support now. The Zig project is also dropping macOS 12 support now. This commit also bumps default minimum macos version to 13.
andrewrk
force-pushed
the
fix-broken-pipe
branch
from
54a7742 to
f6392b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17483
bonus commit: std.process.Child: explicit error set for wait
bonus commit 2: update GitHub-hosted macOS runner to 13. Apple has already dropped support for macOS 12. GitHub Actions is dropping macOS 12 support now. The Zig project is also dropping macOS 12 support now.