Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loongarch: add loongarch64 support #20915

Merged
merged 19 commits into from
Aug 9, 2024
Merged

loongarch: add loongarch64 support #20915

merged 19 commits into from
Aug 9, 2024

Conversation

yxd-ym
Copy link
Contributor

@yxd-ym yxd-ym commented Aug 3, 2024

Port patches from yxd-ym/zig-bootstrap#1

@yxd-ym yxd-ym requested a review from kprotty as a code owner August 3, 2024 04:30
alexrp
alexrp reviewed Aug 3, 2024
View reviewed changes
lib/c.zig Outdated Show resolved Hide resolved
alexrp
alexrp reviewed Aug 3, 2024
View reviewed changes
lib/c.zig Outdated Show resolved Hide resolved
alexrp
alexrp reviewed Aug 3, 2024
View reviewed changes
lib/c.zig Outdated Show resolved Hide resolved
@yxd-ym yxd-ym changed the title loongarch: add loongarch64 support [WIP] loongarch: add loongarch64 support Aug 3, 2024
alexrp
alexrp reviewed Aug 3, 2024
View reviewed changes
lib/c.zig Outdated Show resolved Hide resolved
@yxd-ym yxd-ym changed the title [WIP] loongarch: add loongarch64 support loongarch: add loongarch64 support Aug 3, 2024
@alexrp
Copy link
Member

alexrp commented Aug 3, 2024

LGTM, but note the CI failure due to tabs.

alexrp
alexrp reviewed Aug 4, 2024
View reviewed changes
lib/std/os/linux.zig Outdated Show resolved Hide resolved
alexrp
alexrp reviewed Aug 4, 2024
View reviewed changes
lib/std/os/linux.zig Outdated Show resolved Hide resolved
alexrp
alexrp approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@alexrp alexrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm done nitpicking; this looks mergeable to me. 🙂

@andrewrk andrewrk enabled auto-merge (squash) August 7, 2024 20:08
@andrewrk andrewrk merged commit a9b65b6 into ziglang:master Aug 9, 2024
10 checks passed
@yxd-ym yxd-ym deleted the add-loongarch branch August 9, 2024 01:40
igor84 pushed a commit to igor84/zig that referenced this pull request Aug 11, 2024
@yxd-ym @alexrp
std: add loongarch64 support (ziglang#20915)
8cd1cb6 
Co-authored-by: Alex Rønne Petersen <[email protected]>
SammyJames pushed a commit to SammyJames/zig that referenced this pull request Aug 13, 2024
@yxd-ym @alexrp @SammyJames
std: add loongarch64 support (ziglang#20915)
1c4125b 
Co-authored-by: Alex Rønne Petersen <[email protected]>
Rexicon226 pushed a commit to Rexicon226/zig that referenced this pull request Aug 13, 2024
@yxd-ym @alexrp @Rexicon226
std: add loongarch64 support (ziglang#20915)
fee9e09 
Co-authored-by: Alex Rønne Petersen <[email protected]>
richerfu pushed a commit to richerfu/zig that referenced this pull request Oct 28, 2024
@yxd-ym @alexrp @richerfu
std: add loongarch64 support (ziglang#20915)
7258912 
Co-authored-by: Alex Rønne Petersen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrp alexrp alexrp approved these changes

@kprotty kprotty Awaiting requested review from kprotty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yxd-ym @alexrp @andrewrk