Remove stack option from @call
#13907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
force-pushed
the
call-merge
branch
3 times, most recently
from
2f72cad to
a169b90
Compare
Vexu
force-pushed
the
call-merge
branch
2 times, most recently
from
9812142 to
709a2d6
Compare
krichprollsch
added a commit
to lightpanda-io/zig-js-runtime
that referenced
this pull request
Sep 13, 2023
|
Hi! Is there a way to call function inside a naked function in an elegant way (preferably without using assembly) after removal of stack option from I am trying to do bare bones (kernel) in Zig and apparently this feature was still present in Zig 0.12 - version used in the tutorial, but not in Zig 0.13.0, which I currently have. |
|
Hi! please reserve more question-oriented issues for one of the wonderful Communitys, we'd be happy to help you over there :D |
|
@originalmk Please see my comments here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggested removing thestackfield fromCallOptionssince we don't have a concept of partially comptime structs so having themodifierbe comptime and allowing runtime values forstackdoesn't work well. Andrew suggested to instead combine@calland@asyncCallso that is what this PR does.After a brief discussion it was decided that
@asyncCallneeds to be a separate builtinand that.async_kwModifier should be removed instead